Update generator throttler to support block-based strategy #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
3 times, most recently
from
c4199fc to
6ed7dca
Compare
TheSafo
changed the title
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
11 times, most recently
from
a5dc28f to
10ba2f9
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
10ba2f9 to
d724a4c
Compare
TheSafo
changed the base branch from
graphite-base/1675
to
jsaf/throttle-error-change
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
4 times, most recently
from
74c2f05 to
9ae8ce6
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
2 times, most recently
from
3c1df18 to
01c4cd3
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
a636e4c to
661d654
Compare
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
af8d207 to
cf2d888
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
3 times, most recently
from
e1d8abc to
e73bb21
Compare
TheSafo
changed the title
Draft
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
cf2d888 to
e564637
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
e73bb21 to
57bce08
Compare
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
e564637 to
a1be97c
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
57bce08 to
a47d241
Compare
blt
approved these changes
Jan 20, 2026
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
a47d241 to
88ac56e
Compare
TheSafo
force-pushed
the
jsaf/add-config-tests
branch
from
a1be97c to
47e1784
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
88ac56e to
1692f26
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
gh-worker-dd-mergequeue-cf854d
bot
deleted the
jsaf/block-based-limiter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables configuring byte-based throttlers in generators to be based per block (e.g. 10 blocks per second instead of 100 MB/s).
Impl. details:
Motivation
When using payload generators where blocks are intentionally not the same size/close to maximum bytes, it can be helpful to reason about throughput per block. This allows us to do things like:
to simulate generating logs at 5x standard playback speed.
Related issues
A follow up pr (#1683) adds some flushing logic to BufWriter based generators that enables more regular flushing. A separate PR will introduce a new payload format to utilize block-based throttling.